fix: run pytest hook on unstaged files #347
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that all
make check
variants run theirpre-commit
hooks on unstaged files by using the--all-files
command line option:python-package-template/Makefile
Lines 157 to 166 in f41b0e6
However, running
make test
does not specify that optionpython-package-template/Makefile
Lines 170 to 171 in f41b0e6
and thus stashes changes before running:
This change uses the
--files
command line option (which is similar to the--all-files
) and nowmake test
no longer stashes changes before running.