Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: the ‘upgrade-quiet’ Makefile goal now works with BSD date command too #335

Merged
merged 1 commit into from
Oct 7, 2022
Merged

fix: the ‘upgrade-quiet’ Makefile goal now works with BSD date command too #335

merged 1 commit into from
Oct 7, 2022

Conversation

jenstroeger
Copy link
Owner

@jenstroeger jenstroeger commented Oct 4, 2022 •
edited
Loading

Closes #334

With GNU date:

> make upgrade-quiet 
echo "Automatically generated by Python Package Makefile on `date '+%Y-%m-%d %H:%M:%S %z'`." > .venv/upgraded-on
> cat .venv/upgraded-on 
Automatically generated by Python Package Makefile on 2022-10-04 23:42:29 +1000.

and with BSD date:

> make upgrade-quiet 
echo "Automatically generated by Python Package Makefile on `/bin/date '+%Y-%m-%d %H:%M:%S %z'`." > .venv/upgraded-on
> cat .venv/upgraded-on 
Automatically generated by Python Package Makefile on 2022-10-04 23:47:21 +1000.

@jenstroeger jenstroeger requested a review from behnazh October 4, 2022 13:45
@jenstroeger jenstroeger changed the base branch from main to staging October 4, 2022 14:00
@jenstroeger jenstroeger merged commit f431994 into staging Oct 7, 2022
@jenstroeger jenstroeger mentioned this pull request Oct 27, 2022
Closed
@jenstroeger jenstroeger deleted the fix-issue-334 branch October 30, 2022 05:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@behnazh behnazh behnazh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve use of date parameters to be more portable.
2 participants
@jenstroeger @behnazh