Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ci): fix release workflow #305

Merged
merged 2 commits into from
Sep 1, 2022
Merged

fix(ci): fix release workflow #305

merged 2 commits into from
Sep 1, 2022

Conversation

behnazh
Copy link
Collaborator

@behnazh behnazh commented Sep 1, 2022

No description provided.

@behnazh behnazh requested a review from jenstroeger September 1, 2022 07:58
@jenstroeger
Copy link
Owner

jenstroeger commented Sep 1, 2022 •
edited
Loading

Want to merge straight to main? Also, very technically, these are two fixes, right? One for the release title, one to prevent a release when merging to staging?

@behnazh behnazh requested a review from jenstroeger September 1, 2022 08:09
@behnazh
Copy link
Collaborator Author

behnazh commented Sep 1, 2022

Want to merge straight to main? Also, very technically, these are two fixes, right? One for the release title, one to prevent a release when merging to staging?

Happy to merge to main. And yes, technically, these are two fixes.

@behnazh behnazh changed the base branch from staging to main September 1, 2022 08:11
@behnazh behnazh changed the title fix(ci): fix release title fix(ci): fix release workflow Sep 1, 2022
@behnazh behnazh merged commit c48d7ef into main Sep 1, 2022
@jenstroeger jenstroeger deleted the fix-release-action branch September 1, 2022 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jenstroeger jenstroeger jenstroeger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@behnazh @jenstroeger