refactor(ci): improve the release workflow #303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jenstroeger
reviewed
Sep 1, 2022
There was a problem hiding this comment.
Oh nice, thank you @behnazh! You know, I wonder if we can utilize the commitizen-action 🤔
And to be sure, on PR the build.yaml also builds and stores the artifacts with the workflow, right?
I thought we wanted to avoid using third-party GHAs when we switched from semantic release? Especially in this case we need to give |
Yes, see the artifacts here. |
behnazh
force-pushed
the
improve-release-gha
branch
from
14c9c10 to
832d493
Compare
This was referenced Sep 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #302 #301