Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix type mismatch on $userAgent parameters #135

Merged
merged 1 commit into from
Jan 4, 2019
Merged

Fix type mismatch on $userAgent parameters #135

merged 1 commit into from
Jan 4, 2019

Conversation

nesk
Copy link
Contributor

@nesk nesk commented Jan 3, 2019

Just added PHPStan to a project using Agent and noticed the type hinting of the $userAgent parameter is wrong, it should be @param string|null $userAgent instead of @param null $userAgent.

@jenssegers jenssegers merged commit 59f35c4 into jenssegers:master Jan 4, 2019
@jenssegers
Copy link
Owner

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nesk @jenssegers