Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor deprecated pkg_resources usage #176

Merged
merged 1 commit into from
Dec 10, 2023

Conversation

speleo3
Copy link
Collaborator

@speleo3 speleo3 commented Dec 10, 2023

  • Remove deprecated pkg_resources usage
  • Locate resources relative to __file__
  • Support egg/zip with open_file_for_reading

- Locate resources relative to `__file__`
- Support egg/zip with `open_file_for_reading`
Copy link

codecov bot commented Dec 10, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a62e2a4) 72.98% compared to head (50f62c6) 73.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #176      +/-   ##
==========================================
+ Coverage   72.98%   73.00%   +0.01%     
==========================================
  Files          25       25              
  Lines        4017     4027      +10     
==========================================
+ Hits         2932     2940       +8     
- Misses       1085     1087       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sobolevnrm
Copy link
Collaborator

Looks great!

@speleo3 speleo3 merged commit 83c1721 into jensengroup:master Dec 10, 2023
8 checks passed
@speleo3 speleo3 deleted the replace-pkg_resources branch December 10, 2023 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants