Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve MolecularContainer.top_up_conformations #167

Merged
merged 1 commit into from
Sep 17, 2023

Conversation

speleo3
Copy link
Collaborator

@speleo3 speleo3 commented Sep 17, 2023

Top up from all conformations, not just first.

Fixes #147

Top up from all conformations, not just first.

Fixes jensengroup#147
@codecov
Copy link

codecov bot commented Sep 17, 2023

Codecov Report

Patch coverage: 90.00% and project coverage change: +0.08% 🎉

Comparison is base (fd7b155) 73.08% compared to head (0d6dbfa) 73.17%.

❗ Current head 0d6dbfa differs from pull request most recent head 7d78aca. Consider uploading reports for the commit 7d78aca to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #167      +/-   ##
==========================================
+ Coverage   73.08%   73.17%   +0.08%     
==========================================
  Files          25       25              
  Lines        3972     3977       +5     
==========================================
+ Hits         2903     2910       +7     
+ Misses       1069     1067       -2     
Files Changed Coverage Δ
propka/conformation_container.py 84.97% <85.71%> (-0.05%) ⬇️
propka/molecular_container.py 92.52% <100.00%> (-0.07%) ⬇️

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@sobolevnrm sobolevnrm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@sobolevnrm sobolevnrm merged commit d1d3b37 into jensengroup:master Sep 17, 2023
4 checks passed
@sobolevnrm sobolevnrm mentioned this pull request Sep 17, 2023
@speleo3 speleo3 deleted the top_up_from_atoms branch October 21, 2023 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing atoms or failed protonation
2 participants