Closing dangling file pointers #132
Conversation
| for line in input_: | ||
| parameters.parse_line(line) | ||
| if not stream: |
There was a problem hiding this comment.
Couldn't this be done more cleanly by either checking for duck-typed attributes or simply using isinstance?
|
How about solving this with a context manager (and removing the "TODO - convert this to a context manager" comment)? If you don't mind, I can open a pull request with the solution I have in mind, but I'd also be happy to review yours if you want to give it a try. |
I would vote for the context manager approach. |
|
Sure feel free to open another PR! |
Hi, I was getting lots of warnings about open file pointers so I thought I'd make this PR to resolve the warnings. Also I assume eventually you might hit OS issues if you open too many files while using propka programmatically through python.