Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

propka3 --version prints version #113

Merged
merged 1 commit into from
Dec 9, 2020
Merged

propka3 --version prints version #113

merged 1 commit into from
Dec 9, 2020

Conversation

speleo3
Copy link
Collaborator

@speleo3 speleo3 commented Dec 6, 2020

As far as I can tell, the old --version argument and the version_label option were unused ever since this repo was set up in 2012. This patch changes the --version argument to simply print the program version and exit.

Closes #89

@codecov
Copy link

codecov bot commented Dec 6, 2020

Codecov Report

Merging #113 (42c3b8a) into master (3937cb1) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #113   +/-   ##
=======================================
  Coverage   73.09%   73.09%           
=======================================
  Files          24       24           
  Lines        3958     3959    +1     
=======================================
+ Hits         2893     2894    +1     
  Misses       1065     1065           
Impacted Files Coverage Δ
propka/lib.py 65.95% <100.00%> (+0.24%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3937cb1...283399e. Read the comment docs.

@sobolevnrm sobolevnrm mentioned this pull request Dec 6, 2020
6 tasks
Copy link
Collaborator

@orbeckst orbeckst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The function of --version changed. Even if it didn't work as advertised, it should be noted that functionality changed. (Under semantic versioning this would require a major new release number but I think in this case that might be overkill, especially as it was non-functional.)

Ultimately, @sobolevnrm and you should agree how you want to handle such changes. The package is also historically missing a CHANGELOG so it's hard for users to really understand what changes between versions.

I have a small concern about cyclical imports – it's not enough to block this issue, though.

propka/lib.py Show resolved Hide resolved
propka/lib.py Show resolved Hide resolved
docs/source/command.rst Show resolved Hide resolved
@orbeckst orbeckst merged commit 578b576 into master Dec 9, 2020
@orbeckst orbeckst deleted the issue-89 branch December 9, 2020 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

propka3 --version should print version
3 participants