-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove logging abstraction to facilitate debugging and reduce bloat. #109
Conversation
Also performed minor delinting. Fixes #108
Codecov Report
@@ Coverage Diff @@
## master #109 +/- ##
==========================================
+ Coverage 73.27% 73.31% +0.03%
==========================================
Files 24 24
Lines 3982 3987 +5
==========================================
+ Hits 2918 2923 +5
Misses 1064 1064
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall this looks good.
There's one message that was originally tagged "info" but is clearly "error" – see comment.
It's not clear to me if the default for logging is to show messages and at which level. There should be some user documentation for how to enable different levels. Similarly, is there a commandline option to change the logging level?
_LOGGER.info('CYS-CYS %s', self.CYS_CYS_exception) | ||
|
||
_LOGGER.info('--------------- Mapping -------------------------------') | ||
_LOGGER.info(""" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks like latex, meant to be copied and pasted. Is this used by anyone? If so, perhaps make it easier to grep it from the logs by prefixing every line with some marker such as "LATEX>" or somesuch??
It might not be worth any effort, though. Up to you.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You and @speleo3 know that I love to delete code... and I don't think anyone is using this. I would happily delete if you both agree.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's the same to me – I am pretty sure I never looked at it.
Fixes #109 (comment) based on suggestion from @orbeckst.
Also performed minor delinting.
Fixes #108