Fix BondMaker.put_atom_in_box

Was only populating 8 out of 14 necessary boxes. Fixes #97
jensengroup · Dec 2, 2020 · cc8514e · cc8514e
1 parent 45aa08a
commit cc8514e
Showing 1 changed file with 21 additions and 8 deletions.
diff --git a/propka/bonds.py b/propka/bonds.py
@@ -392,14 +392,27 @@ def put_atom_in_box(self, x, y, z, atom):
             z:  box z-coordinates
             atom:  the atom to place in a box
         """
-        for box_x in [x, x+1]:
-            for box_y in [y, y+1]:
-                for box_z in [z, z+1]:
-                    key = (box_x, box_y, box_z)
-                    try:
-                        self.boxes[key].append(atom)
-                    except KeyError:
-                        pass
+        for (dx, dy, dz) in [
+            (-1, -1, -1),
+            (-1, -1, 0),
+            (-1, -1, 1),
+            (-1, 0, -1),
+            (-1, 0, 0),
+            (-1, 0, 1),
+            (-1, 1, -1),
+            (-1, 1, 0),
+            (-1, 1, 1),
+            (0, -1, -1),
+            (0, -1, 0),
+            (0, -1, 1),
+            (0, 0, -1),
+            (0, 0, 0),
+        ]:
+            key = (x + dx, y + dy, z + dz)
+            try:
+                self.boxes[key].append(atom)
+            except KeyError:
+                pass
 
     @staticmethod
     def has_bond(atom1, atom2):