Adjust adapter gem versions to required versions in Rails #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
It was impossible to run tests on Travis CI due too lose requirements on gem versions. Bundler was loading version too new for specific Rails version.
|
Looks good, thanks for this! 👍 |
|
v0.2.21 has been released with these fixes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was impossible to run tests on Travis CI due too loose requirements on gem versions. Bundler was loading version too new for specific Rails version.
I have copied required versions from
active_record/connection_adapters/*for each adapter*.(*) There was an issue with mysql2 0.4.3 and Rails 5.x so I kept
~> 0.4.4version constraint.