Fix schema.rb with ActiveRecord::Schema[7.0].define #106

andrewjstrominger · 2022-05-17T15:40:41Z

ActiveRecord::Schema[7.0].define(version: 2022_05_17_144011) do

Without Fix:

[1] pry(main)> HairTrigger::migrations_current?
  ActiveRecord::SchemaMigration Pluck (0.5ms)  SELECT "schema_migrations"."version" FROM "schema_migrations" ORDER BY "schema_migrations"."version" ASC
ArgumentError: comparison of NilClass with 20220517144011 failed
from /usr/local/rvm/gems/ruby-3.1.2/gems/hairtrigger-0.2.25/lib/hair_trigger.rb:90:in `sort_by'

With Fix:

[1] pry(main)> HairTrigger::migrations_current?
  ActiveRecord::SchemaMigration Pluck (0.5ms)  SELECT "schema_migrations"."version" FROM "schema_migrations" ORDER BY "schema_migrations"."version" ASC
=> true

alanhala · 2022-06-14T16:02:27Z

Is this gem still maintained? Would be great to have this for newer Rails app as hairtrigger is not currently supporting it.

xiaohui-zhangxh · 2022-10-06T17:12:31Z

lib/hair_trigger.rb

@@ -82,7 +82,7 @@ def current_migrations(options = {})
      if previous_schema = (options.has_key?(:previous_schema) ? options[:previous_schema] : File.exist?(schema_rb_path) && File.read(schema_rb_path))
        base_triggers = MigrationReader.get_triggers(previous_schema, options)
        unless base_triggers.empty?
-          version = (previous_schema =~ /ActiveRecord::Schema\.define\(.*?(\d+)\)/) && $1.to_i
+          version = (previous_schema =~ /ActiveRecord::Schema(\[\d\.\d\])?\.define\(.*?(\d+)\)/) && $1.to_i


should also match underscored version number 2022_10_06_165942

version = (previous_schema =~ /ActiveRecord::Schema(?:\[\d\.\d\])\.define$.*?(\d+(?:_\d+)*)$/) && $1.to_i

jenseng · 2022-12-12T16:09:51Z

Merged #104 which should address this, sorry for the delay! I'll cut a new release shortly

Fix schema.rb with ActiveRecord::Schema[7.0].define

379095d

andrewjstrominger marked this pull request as ready for review May 17, 2022 15:51

xiaohui-zhangxh reviewed Oct 6, 2022

View reviewed changes

bulgakke mentioned this pull request Dec 10, 2022

ArgumentError: comparison of NilClass with 20221210175746 failed #108

Closed

jenseng closed this Dec 12, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix schema.rb with ActiveRecord::Schema[7.0].define #106

Fix schema.rb with ActiveRecord::Schema[7.0].define #106

andrewjstrominger commented May 17, 2022

alanhala commented Jun 14, 2022

xiaohui-zhangxh Oct 6, 2022

jenseng commented Dec 12, 2022

Fix schema.rb with ActiveRecord::Schema[7.0].define #106

Fix schema.rb with ActiveRecord::Schema[7.0].define #106

Conversation

andrewjstrominger commented May 17, 2022

alanhala commented Jun 14, 2022

xiaohui-zhangxh Oct 6, 2022

Choose a reason for hiding this comment

jenseng commented Dec 12, 2022