Fix for IconTaskNode positioning #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your help making these updates @jeff-phillips-18 |
jenny-s51
approved these changes
Apr 4, 2024
jenny-s51
pushed a commit
that referenced
this pull request
Nov 4, 2024
* test: added mocks and interceptors for nim cypress tests Signed-off-by: Tomer Figenblat <[email protected]> * Merging the base test cases of Daniel and Lokesh's code to the Tomer's standalone cypress test suite. * Reverting the mock changes which are not needed. * nim-specific classes and functions, partial rework of deployment test (#2) Signed-off-by: Daniele Martinoli <[email protected]> * Checking in the cypress test covers to validate all the scenarios to render nim and all other cards on overview and model tab when there are no ServingRuntimes configured. * Added mockNimServingRuntimeTemplate mock function Signed-off-by: Daniele Martinoli <[email protected]> * mocking deploy respurces (WIP) Signed-off-by: Daniele Martinoli <[email protected]> * Completed deployment tests Signed-off-by: Daniele Martinoli <[email protected]> * Added new test cases to validate if the nim is not enabled * when combination of configurations to enable nim models are not configured properly. * test: added test cases for deleting model from the project models tab Signed-off-by: Tomer Figenblat <[email protected]> * * Added new test cases to validate the model serving menu item when there are deployments and no deployments. (#9) * Moved the utility method to nimUtils.ts * test: cleanups Signed-off-by: Tomer Figenblat <[email protected]> * adding const for modal dialog title Signed-off-by: Daniele Martinoli <[email protected]> * test cases for list of models in different pages/tabs Signed-off-by: Daniele Martinoli <[email protected]> * linting fixes Signed-off-by: Daniele Martinoli <[email protected]> * removed experimentalStudio option Signed-off-by: Daniele Martinoli <[email protected]> * test: split nim tests per pages (#13) Signed-off-by: Tomer Figenblat <[email protected]> * testing more buttons in modal dialog (#14) Signed-off-by: Daniele Martinoli <[email protected]> * Added a test case to address there is a failure in loading Nvidia Nim model images then error message should be displayed. Added experimentalStudio flag to cypress.config.ts but disabled it by default. * Added a test case to address there is a failure in loading Nvidia Nim model images then error message should be displayed. Added experimentalStudio flag to cypress.config.ts but disabled it by default. * test: fix linting errors Signed-off-by: Tomer Figenblat <[email protected]> * test: fix review change requests 1 - see body - Use JSON object instead of string in mocking of NIM images configmap - Remove experiementalStudio cypres config param - Add mock for NIM project Co-authored-by: Daniele Martinoli <[email protected]> Co-authored-by: lokeshrangineni <[email protected]> Signed-off-by: Tomer Figenblat <[email protected]> * test: fix review change requests 2 - see body - Add nim-serving interception to odh intercept type safety mechanism - Add accelerators interception to odh intercept type safety mechanism Co-authored-by: Daniele Martinoli <[email protected]> Co-authored-by: lokeshrangineni <[email protected]> Signed-off-by: Tomer Figenblat <[email protected]> * test: create page objects for verifying nim model tabels Co-authored-by: Daniele Martinoli <[email protected]> Co-authored-by: lokeshrangineni <[email protected]> Signed-off-by: Tomer Figenblat <[email protected]> * Update frontend/src/__tests__/cypress/cypress/tests/mocked/projects/modelServingNim.cy.ts Co-authored-by: Andrew Ballantyne <[email protected]> * test: fix linting errors Signed-off-by: Tomer Figenblat <[email protected]> * test: rewrite test case for global model list nim Signed-off-by: Tomer Figenblat <[email protected]> * test: fix linting errors Signed-off-by: Tomer Figenblat <[email protected]> * test: rewrite test case for project overview list nim Signed-off-by: Tomer Figenblat <[email protected]> * test: rewrite test case for project models tab list nim Signed-off-by: Tomer Figenblat <[email protected]> * test: cleanups Signed-off-by: Tomer Figenblat <[email protected]> * test: rewrite test cases nim enablement Signed-off-by: Tomer Figenblat <[email protected]> * test: final touchups Signed-off-by: Tomer Figenblat <[email protected]> * test: fixing 1 of 2 failing tests after rebase Signed-off-by: Tomer Figenblat <[email protected]> * test: fix mockInfereceService should take labels co-authored-by: Andrew Ballantyne <[email protected]> Signed-off-by: Tomer Figenblat <[email protected]> * test: fix review suggestion for global model edit button co-authored-by: Andrew Ballantyne <[email protected]> Signed-off-by: Tomer Figenblat <[email protected]> --------- Signed-off-by: Tomer Figenblat <[email protected]> Signed-off-by: Daniele Martinoli <[email protected]> Co-authored-by: Tomer Figenblat <[email protected]> Co-authored-by: Lokesh Rangineni <[email protected]> Co-authored-by: lokeshrangineni <[email protected]> Co-authored-by: Andrew Ballantyne <[email protected]> Co-authored-by: Andrew Ballantyne <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.