[RHOAIENG-10305]: Apply token theming to RegisteredModelListView.tsx #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jenny-s51
commented
Aug 13, 2024
There was a problem hiding this comment.
Reverted to CSS stylesheet following conversations with @mcoker and @srambach , we also bumped the PF versions, fixed an alignment issue in the v6 masthead, and added a fix in index.html to apply the Roboto font used by MUI.
In progress: theme toggle to toggle MUI theming on/off in Model Registry view as part of this POC, remaining tokens/style issues in dropdown and search filters currently being investigated by @mcoker
|
Closing as the work for RHOAIENG-10305 is complete - these updates will be migrated to https://github.com/kubeflow/model-registry as part of RHOAIENG-11419 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP, towards RHOAIENG-10305. Working on applying theming to split button dropdown and fixing UI issues with toolbar alignment