remove key, add aria-describedBy,format

jenny-s51 · Nov 4, 2024 · 465607a · 465607a
1 parent 3a75b9d
commit 465607a
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 7 deletions.
diff --git a/frontend/src/pages/projects/screens/detail/connections/ConnectionsList.tsx b/frontend/src/pages/projects/screens/detail/connections/ConnectionsList.tsx
@@ -75,7 +75,6 @@ const ConnectionsList: React.FC = () => {
             createButton={
               <>
                 <Button
-                  key={`action-${ProjectSectionID.CONNECTIONS}`}
                   variant="primary"
                   data-testid="create-connection-button"
                   aria-describedby={
@@ -90,11 +89,7 @@ const ConnectionsList: React.FC = () => {
                   Create connection
                 </Button>
                 {enabledConnectionTypes.length === 0 && (
-                  <Tooltip
-                    id="no-connection-types-tooltip"
-                    content="No connection types available"
-                    triggerRef={tooltipRef}
-                  />
+                  <Tooltip content="No connection types available" triggerRef={tooltipRef} />
                 )}
               </>
             }

diff --git a/frontend/src/pages/projects/screens/spawner/connections/ConnectionsFormSection.tsx b/frontend/src/pages/projects/screens/spawner/connections/ConnectionsFormSection.tsx
@@ -17,7 +17,10 @@ import { createSecret, replaceSecret } from '~/api';
 import { NotebookKind, ProjectKind } from '~/k8sTypes';
 import { getDisplayNameFromK8sResource } from '~/concepts/k8s/utils';
 import { Connection, ConnectionTypeConfigMapObj } from '~/concepts/connectionTypes/types';
-import { filterEnabledConnectionTypes, getConnectionTypeDisplayName } from '~/concepts/connectionTypes/utils';
+import {
+  filterEnabledConnectionTypes,
+  getConnectionTypeDisplayName,
+} from '~/concepts/connectionTypes/utils';
 import { useWatchConnectionTypes } from '~/utilities/useWatchConnectionTypes';
 import { useNotebooksStates } from '~/pages/projects/notebook/useNotebooksStates';
 import { SpawnerPageSectionTitles } from '~/pages/projects/screens/spawner/const';
@@ -143,6 +146,9 @@ export const ConnectionsFormSection: React.FC<Props> = ({
           <FlexItem>
             <Button
               data-testid="create-connection-button"
+              aria-describedby={
+                unselectedConnections.length === 0 ? 'no-connection-types-tooltip' : undefined
+              }
               variant="secondary"
               id="no-connection-types-tooltip"
               content="No connection types available"