Use explicit group ID #76
Conversation
|
HI @car-roll, the use of an interpolated variable in the group ID is tripping up my new code in Maven HPI plugin for JENKINS-45047. While I could probably fix it with some more effort, this is the only case where it is a problem and I think it would be easier to ignore the problem by just spelling out the dependency name. 😄 A release of this can help me move on and focus on other problems necessary to get |
| @@ -61,7 +61,7 @@ | |||
| </dependencyManagement> | |||
| <dependencies> | |||
| <dependency> | |||
| <groupId>${project.groupId}</groupId> | |||
| <groupId>org.jenkins-ci.plugins.workflow</groupId> | |||
There was a problem hiding this comment.
Can we mark a comment or TODO here? Otherwise I feel like this will get reverted by some well-meaning individual and some maintainer (including myself) will not realize and let it through.
There was a problem hiding this comment.
I don't understand what kind of comment you want to see. Referring to group IDs by their literal form rather than an interpolated string is the norm, not the exception. Moreover, I don't see what action there is to take, so I'm not sure what kind of TODO to write.
There was a problem hiding this comment.
Referring to group IDs by their literal form rather than an interpolated string is the norm, not the exception
That was my confusion. I thought it was the other way around, so I thought someone in the future might accidentally clean up the pom and give you trouble down the road. If that's the case, then no action needed.
|
Thanks! Any chance of a release for |
|
FYI I'm down to 4 plugins pending releases in jenkinsci/bom#1059 (this one, |
|
sorry, ping got lost in my notifications noise. How strange the developer tag didn't trigger the build. I can check on |
No description provided.