Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refine content and appearance of the project 'Configure' screen #479

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

janfaracik
Copy link
Contributor

@janfaracik janfaracik commented Oct 19, 2024

Relates to jenkinsci/jenkins#9734.

Key changes

  • The 'Build Triggers' section has been updated to feature the same content changes as core, it's now just 'Triggers' and there is now a description
  • Pipeline section has been moved above 'Advanced' and a description has been added
  • 'Quiet period' has been moved to 'Advanced', consistent with core
image

Removal of Pipeline Syntax link in jenkinsci/workflow-cps-plugin#946

Testing done

  • Works as before

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@@ -64,7 +64,8 @@
<properties>
<changelist>999999-SNAPSHOT</changelist>
<!-- TODO: Waiting for JENKINS-73824 and JENKINS-73835 to make it into an LTS line -->
<jenkins.version>2.481</jenkins.version>
<!-- <jenkins.version>2.481</jenkins.version> -->
<jenkins.version>2.481-rc35491.56cb_9df6e9cd</jenkins.version>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be in draft so long as this is using an incremental version.

@@ -0,0 +1 @@
pipeline.description=Define your Pipeline using Groovy directly or pull it from source control. Check the <a target="_blank" href="./pipeline-syntax">Pipeline Syntax</a> page for guidance on writing pipelines.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A bit pedantic, but the pipeline-syntax link is actually defined in workflow-cps and specific to those FlowDefinition implementations. Can this blurb be kept in workflow-cps, and just shifted up in the config.jelly? Or can this aspect of the redesign be split out for separate consideration so we can go ahead with the rest, which certainly seems welcome?

@jglick jglick requested a review from daniel-beck November 7, 2024 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants