-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[JENKINS-52165] Stabilize and better test USE_WATCHING
#323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
… mode since the `NewlineSafeTaskListener` was already closed by `HandlerImpl.exited`
…ShellScriptAcrossDisconnect` & `.contextualizeFreshFilePathAfterAgentReconnection`
This comment was marked as resolved.
This comment was marked as resolved.
This was referenced Jul 7, 2023
This was referenced Jul 13, 2023
jglick
commented
Jul 13, 2023
jglick
commented
Jul 13, 2023
car-roll
approved these changes
Jul 20, 2023
This comment was marked as resolved.
This comment was marked as resolved.
…e-task-step-plugin into USE_WATCHING-JENKINS-52165
This was referenced Jul 27, 2023
…e-task-step-plugin into USE_WATCHING-JENKINS-52165
jglick
changed the title
[JENKINS-52165] Enable
[JENKINS-52165] Stabilize and better test Jul 28, 2023
USE_WATCHING
by defaultUSE_WATCHING
dwnusbaum
approved these changes
Jul 28, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have been following this off and on in the background. I have not attempted to fully trace the reasoning behind each individual change, but I know you have tested things reasonably thoroughly, and I do not see anything that looks obviously problematic.
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JENKINS-52165: the performance benefits seem important. Have not yet tried to measure impact on (controller) CPU or Remoting channel bandwidth, but can use inotify to verify this allows a long-running
sh
step with copious output to only write tolog
(and maybelog-index
), whereas in currently default pull mode there are constant writes toprogram.dat
(via an atomic temp file) due toworkflow-durable-task-step-plugin/src/main/java/org/jenkinsci/plugins/workflow/steps/durable_task/DurableTaskStep.java
Lines 599 to 601 in 6f24fa9
Downstream of jenkinsci/workflow-api-plugin#294 and jenkinsci/durable-task-plugin#186.
TaskListenerDecorator.decorate
even when wrapped withmerge
workflow-api-plugin#290 & Unnecessary use of Guava inStatusCheck
durable-task-plugin#185DurableTaskStep.HandlerImpl.printStreamDelegate
requires--add-opens
#212 more cleanlyUSE_WATCHING
bom#2246 and CloudBees CI)pipeline-cloudwatch-logs
KubernetesPipelineOverridenNamespaceTest
USE_WATCHING
#323 (comment)