[JENKINS-49707] Defining AgentErrorCondition
#231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12 tasks
jglick
commented
Jun 3, 2022
| } | ||
| if (t instanceof MissingContextVariableException) { | ||
| Class<?> type = ((MissingContextVariableException) t).getType(); | ||
| // See ExecutorStepDynamicContext for four explicitly advertised types, & DefaultStepContext for two implicitly derived ones. |
There was a problem hiding this comment.
Comment really belongs in #180, and perhaps this whole MissingContextVariableException clause might be active only in that mode, but seems harmless enough to include this logic here.
jglick
added a commit
to jglick/pipeline-model-definition-plugin
that referenced
this pull request
Jun 3, 2022
…nkinsci/workflow-basic-steps-plugin#203 since we have no restart tests here
This was referenced Jun 3, 2022
jtnord
reviewed
Jun 6, 2022
src/main/java/org/jenkinsci/plugins/workflow/support/steps/AgentErrorCondition.java
Outdated
Show resolved
Hide resolved
jtnord
reviewed
Jun 6, 2022
| } | ||
| } | ||
|
|
||
| @Symbol("agent") |
There was a problem hiding this comment.
noting collision with (a probably very rarely installed plugin - only alpha releases afaict)
There was a problem hiding this comment.
Should be OK. https://javadoc.jenkins.io/component/symbol-annotation/org/jenkinsci/Symbol.html
symbol names are meant to be only unique within a specific extension point
jtnord
reviewed
Jun 6, 2022
car-roll
approved these changes
Jun 7, 2022
fcojfernandez
approved these changes
Jun 7, 2022
jtnord
approved these changes
Jun 7, 2022
jglick
added a commit
to jglick/workflow-basic-steps-plugin
that referenced
this pull request
Jul 7, 2022
jglick
added a commit
to jglick/kubernetes-plugin
that referenced
this pull request
Jul 7, 2022
This was referenced Jul 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JENKINS-49707
Extracted from #180, containing just the logic needed to retry
nodeblocks (on nonspecific agents) in the face of errors encountered while the controller is still running. The larger changes in #180 would be needed to handle errors spanning a controller restart, such as an agent which fails to reconnect because it has been lost forever after a backup & restore into another cluster.Downstream of jenkinsci/workflow-api-plugin#217.