Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nicer build log message when ExecutorPickle fails to resume #175

Merged
merged 1 commit into from
Oct 8, 2021

Conversation

jglick
Copy link
Member

@jglick jglick commented Oct 7, 2021

#47 (comment)

In

Thread.sleep(ExecutorPickle.TIMEOUT_WAITING_FOR_NODE_MILLIS + 1000L);
Assert.assertEquals("Should have given up and killed the Task representing the resuming build", 0, Queue.getInstance().getItems().length );
Assert.assertFalse(run.isBuilding());
j.assertBuildStatus(Result.FAILURE, run);

Before:

[p #1] ERROR: Killed hudson.model.Queue$BuildableItem:ExecutorStepExecution.PlaceholderTask{runId=p#1,label=slave0,context=CpsStepContext[3:node]:Owner[p/1:p #1],cookie=1f900f85-0501-4f30-83d9-4a8a9ed1f70a,auth=null}:3 after waiting for 15,000 ms because we assume unknown Node slave0 is never going to appear!

After:

[p #1] ERROR: Killed part of p #1 after waiting for 15,000 ms because we assume unknown Node slave0 is never going to appear!

@car-roll car-roll added the chore label Oct 8, 2021
@car-roll car-roll merged commit c2bb8f5 into jenkinsci:master Oct 8, 2021
@jglick
Copy link
Member Author

jglick commented Oct 8, 2021

@car-roll this is more enhancement than chore I think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants