Backport #877 to 3653.x #879
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
More efficient use of `GroovyCategorySupport` (cherry picked from commit d0f0248)
dwnusbaum
commented
Apr 2, 2024
| @@ -177,4 +214,32 @@ private void tearDown(ThreadContext context) { | |||
| static ThreadLocal<ClassLoader> ORIGINAL_CONTEXT_CLASS_LOADER = new ThreadLocal<>(); | |||
|
|
|||
| private static final Logger LOGGER = Logger.getLogger(CpsVmExecutorService.class.getName()); | |||
|
|
|||
| // NOTE: Copied from Jenkins core when backporting d0f0248b to avoid having to update dependencies. | |||
There was a problem hiding this comment.
Discussed in the PR description.
rsandell
approved these changes
Apr 3, 2024
jglick
approved these changes
Apr 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backports #877 to 3653.x.
Note that I copied
ErrorLoggingExecutorServicefrom core (jenkinsci/jenkins#7284) intoCpsVmExecutorServiceas an inner class to avoid having to update dependencies here. If preferred, we could instead update dependencies, or just drop theErrorLoggingExecutorServicefromthreadPoolin the backport.Testing done
Submitter checklist