Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flush overall Pipeline log stream when shutting down Jenkins #669

Merged
merged 5 commits into from
Mar 7, 2023
Merged

Flush overall Pipeline log stream when shutting down Jenkins #669

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
4169906
Flush overall Pipeline log stream when shutting down Jenkins
dwnusbaum Mar 3, 2023
479665f
Add regression test using RealJenkinsRule
dwnusbaum Mar 3, 2023
c144a2b
Enhance logging to diagnose CpsFlowDefinitionRJRTest.flushLogsOnShutd…
dwnusbaum Mar 6, 2023
d49313e
Update Jenkins version to try to diagnose CpsFlowDefinitionRJRTest.fl…
dwnusbaum Mar 6, 2023
6888d82
Skip CpsFlowDefinitionRJRTest.flushLogsOnShutdown on Windows for now
dwnusbaum Mar 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions plugin/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,7 @@
<node.version>18.13.0</node.version>
<npm.version>8.19.3</npm.version>
<yarn.version>1.22.19</yarn.version>
<jenkins-test-harness.version>1926.v9b_323a_4da_421</jenkins-test-harness.version> <!-- Temporary, required to diagnose RJR issues due to https://github.com/jenkinsci/jenkins-test-harness/pull/544#issuecomment-1456707299 -->
dwnusbaum marked this conversation as resolved.
Show resolved Hide resolved
</properties>
<dependencyManagement>
<dependencies>
Expand Down
2 changes: 2 additions & 0 deletions plugin/src/test/java/org/jenkinsci/plugins/workflow/cps/CpsFlowDefinitionRJRTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
package org.jenkinsci.plugins.workflow.cps;

import java.util.logging.Level;
import org.jenkinsci.plugins.workflow.job.WorkflowJob;
import org.jenkinsci.plugins.workflow.job.WorkflowRun;
import org.junit.Rule;
Expand All @@ -25,6 +26,7 @@ private static void doesItSmoke(JenkinsRule r) throws Exception {

@Test
public void flushLogsOnShutdown() throws Throwable {
rjr.withLogger(CpsFlowExecution.class, Level.FINER);
rjr.then(CpsFlowDefinitionRJRTest::flushLogsOnShutdownPreRestart);
rjr.then(CpsFlowDefinitionRJRTest::flushLogsOnShutdownPostRestart);
}
Expand Down