-
Notifications
You must be signed in to change notification settings - Fork 194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[JENKINS-63164] Clear fields in CpsThread when thread is removed from CpsThreadGroup #368
Conversation
@@ -419,6 +419,7 @@ private boolean run() { | |||
t.fireCompletionHandlers(o); // do this after ErrorAction is set above | |||
|
|||
threads.remove(t.id); | |||
t.cleanUp(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I like this better than #367 because it seems like there's fewer paths in which this call could be missed but I might not be understanding.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I cannot say that this is right, either, but at least it strikes me as more intuitive.
@bitwiseman I added some assertions for The other fields we clean up are all nullable, so it doesn't really make sense to add assertions around them. |
Underlying issue was fixed by jenkinsci#368.
See #367. This is the first alternative discussed in #367 (comment).