Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JENKINS-48431 Support both lightweight checkout AND build parameters #329

Closed
wants to merge 1 commit into from

Conversation

tgatinea
Copy link

@tgatinea tgatinea commented Oct 14, 2019

JENKINS-48431 To support both lightweight checkout AND build parameters, we need to:

  • recover the environment parameters of the build
  • evaluate the SCM structure according to the build environment parameters

This leads to implement a new method :
public static SCMFileSystem of(@nonnull Run build, @nonnull SCM scm, @checkfornull SCMRevision rev)

This new method offer the capacity to recover the environments parameter of the build as the current build is propagated through the new method.

Note that this modification is in relation with two other pull requests that concerns:

Comment on lines -5 to -6
Also build parameters will not be substituted into SCM configuration in this mode.
Only selected SCM plugins support this mode.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is important to still note that not all SCMs that support lightweight checkouts, and that even the ones that do support lightweight checkout do not all support build parameters, so maybe change the wording to something like this instead:

Only selected SCM plugins support this mode.
Build parameters may be substituted into SCM configuration in this mode when running SCM API plugin X.Y.Z or newer. Not all SCM plugins support this feature.

@jglick
Copy link
Member

jglick commented Aug 5, 2022

Superseded by #577?

@dwnusbaum
Copy link
Member

Superseded by #577?

Yeah looks like it, so I am closing this PR.

@dwnusbaum dwnusbaum closed this Nov 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants