-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding LICENSE file. #77
Conversation
I'm not sure about this. In pom.xml we already declare that we are using the MIT license: workflow-cps-global-lib-plugin/pom.xml Line 42 in ff614b7
Is that not enough? Each file should have its own license header with the author who submitted the change. If we created a file in the root, would we need to include all of those authors in the main file and then update the date? |
It is good to have a dedicated License file. Not every project will have a pom.xml and when someone is looking for a place to find what license a project is open sourced under than he'll generally look for a license file. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would not hurt. Some tools (including GitHub itself) rely on the license metadata exposed by GitHub API. it comes from this file, and Maven pom.xml is not sourced ATM
@oleg-nenashev Do you know though if this is the right way to do it, given there are many independent copyright owners listed in the headers in this plugin? I am not sure if it matters or not:
|
I just append "and all other contributors" in the end of the line.
…On Wed, Dec 11, 2019 at 3:22 PM Devin Nusbaum ***@***.***> wrote:
@oleg-nenashev <https://github.com/oleg-nenashev> Do you know though if
we this is the right way to do it, given there are many independent
copyright owners listed in the headers in this plugin? I am not sure if it
matters or not:
If we created a file in the root, would we need to include all of those
authors in the main file and then update the date?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#77?email_source=notifications&email_token=AAW4RIHRAK3CK3LNAT7HXBLQYDZS7A5CNFSM4IMEDRLKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEGTJJ3I#issuecomment-564565229>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAW4RIGYU4SWLIRH6T4RH3DQYDZS7ANCNFSM4IMEDRLA>
.
|
No description provided.