Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding LICENSE file. #77

Merged
merged 2 commits into from
Jan 24, 2022
Merged

Adding LICENSE file. #77

merged 2 commits into from
Jan 24, 2022

Conversation

kshithijiyer
Copy link
Contributor

No description provided.

@dwnusbaum
Copy link
Member

I'm not sure about this. In pom.xml we already declare that we are using the MIT license:

<name>MIT License</name>

Is that not enough? Each file should have its own license header with the author who submitted the change. If we created a file in the root, would we need to include all of those authors in the main file and then update the date?

@kshithijiyer
Copy link
Contributor Author

It is good to have a dedicated License file. Not every project will have a pom.xml and when someone is looking for a place to find what license a project is open sourced under than he'll generally look for a license file.

Copy link
Member

@oleg-nenashev oleg-nenashev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would not hurt. Some tools (including GitHub itself) rely on the license metadata exposed by GitHub API. it comes from this file, and Maven pom.xml is not sourced ATM

@dwnusbaum
Copy link
Member

dwnusbaum commented Dec 11, 2019

@oleg-nenashev Do you know though if this is the right way to do it, given there are many independent copyright owners listed in the headers in this plugin? I am not sure if it matters or not:

If we created a file in the root, would we need to include all of those authors in the main file and then update the date?

@oleg-nenashev
Copy link
Member

oleg-nenashev commented Dec 11, 2019 via email

LICENSE Outdated Show resolved Hide resolved
@jglick jglick merged commit d1912e9 into jenkinsci:master Jan 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants