Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small change to pipeline durability description #343

Merged
merged 1 commit into from
Jul 18, 2024
Merged

Small change to pipeline durability description #343

merged 1 commit into from
Jul 18, 2024

Conversation

julieheard
Copy link
Contributor

@julieheard julieheard commented Jul 18, 2024

I have changed the wording on the durability settings to make sure users know that the settings for 'max survivability' and 'max durability' are actually the same thing. Previously to this change, the monitor displays the name of the enum instead of the description for it, making some users think there are 4 different options instead of 3.

I removed the (previously the only option) bit as could'nt see any more info on that in the documentation here and wanted to just trim and make clearer.

Before:
image

After:
image

This change is only description changes on the UI, so nothing to test other than manual tests to see the different wording. I also have a draft docs PR here to sync the wording from this PR.

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

Copy link
Member

@jglick jglick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this looks clearer indeed.

@jglick jglick merged commit 857eeee into jenkinsci:master Jul 18, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants