Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Note that the sort in ForkScanner.leastCommonAncestor does not really implement a topological sort #288

Merged
merged 1 commit into from
Jun 26, 2023
Merged

Note that the sort in ForkScanner.leastCommonAncestor does not really implement a topological sort #288

merged 1 commit into from
Jun 26, 2023

Conversation

dwnusbaum
Copy link
Member

See #287 (comment).

Testing done

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@dwnusbaum dwnusbaum mentioned this pull request Jun 26, 2023
Merged
9 tasks
@jglick jglick merged commit 7b1fdfe into jenkinsci:master Jun 26, 2023
@dwnusbaum dwnusbaum deleted the warning branch July 3, 2023 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jglick jglick jglick approved these changes

Assignees
No one assigned
Labels
chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dwnusbaum @jglick