Modernize to Jenkins 2.375.4 #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use this link to re-run the recipe: https://app.moderne.io/recipes/org.openrewrite.jenkins.ModernizePlugin Co-authored-by: Moderne <[email protected]>
|
Requires building on Java 11+ to go green (#81) |
tomasbjerre
reviewed
Aug 5, 2023
| <dependency> | ||
| <groupId>io.jenkins.tools.bom</groupId> | ||
| <artifactId>bom-2.375.x</artifactId> | ||
| <version>2198.v39c76fc308ca</version> |
There was a problem hiding this comment.
Are you sure this is the correct version to use?
There was a problem hiding this comment.
Yes, it's the most recent release of bom-2.375.x, which corresponds to the jenkins.version above. I see you have dependabot enabled, so that will take care of bumping this version on new releases.
The recommended baseline changes over time and older artifacts stop being published. Ideally sometime in the next quarter we'd bump jenkins.version to 2.387.3 and this bom to the latest release of bom-2.387.x.
Happy to send a PR for that down the road if it helps.
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
This PR aims to modernize tooling and move this plugin to the recommended Jenkins baseline version.
Testing done
Ran
mvn clean verify.Submitter checklist
Use this link to re-run the recipe: https://app.moderne.io/recipes/org.openrewrite.jenkins.ModernizePlugin