Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: ignore certain folders/paths/globs #72

Closed
bgotink opened this issue Nov 30, 2020 · 4 comments
Closed

Feature: ignore certain folders/paths/globs #72

bgotink opened this issue Nov 30, 2020 · 4 comments

Comments

@bgotink
Copy link

bgotink commented Nov 30, 2020

I use this plugin to get eslint warnings in pull requests, but in PRs that contain a lot of changed files (1,000+) that eslint doesn't comment on (in our case: zipfiles) this violation command takes a very long time doing over 1,000 unneeded HTTP requests. This takes easily over 15 minutes if Jenkins / the network / BitBucket is already under a higher than normal load.

It would help a lot if we could tell the command that changes to zipfiles—alternatively, the .yarn/cache folder—won't trigger any warnings so it can skip those.

@tomasbjerre
Copy link
Contributor

Sounds like you have .yarn/cache committed in version control?
You are talking about all the HTTP requests taking a lot of time right?

@bgotink
Copy link
Author

bgotink commented Dec 1, 2020

Sounds like you have .yarn/cache committed in version control?

Indeed. We're using yarn 2, which—by default—places its cache inside the repository. It's a tradeoff between repo size and speed of yarn install / dependency on the npm registry.

You are talking about all the HTTP requests taking a lot of time right?

Yes, the 1,000+ HTTP requests that the plugin makes for those zipfiles take a long time.

tomasbjerre added a commit to tomasbjerre/violations-lib that referenced this issue Dec 6, 2020
tomasbjerre added a commit to tomasbjerre/violation-comments-lib that referenced this issue Dec 6, 2020
tomasbjerre added a commit to tomasbjerre/violations-lib that referenced this issue Dec 6, 2020
tomasbjerre added a commit to tomasbjerre/violation-comments-lib that referenced this issue Dec 6, 2020
tomasbjerre added a commit to tomasbjerre/violation-comments-to-bitbucket-server-lib that referenced this issue Dec 6, 2020
tomasbjerre added a commit to tomasbjerre/violation-comments-to-bitbucket-server-command-line that referenced this issue Dec 6, 2020
tomasbjerre added a commit to tomasbjerre/violation-comments-to-bitbucket-server-command-line that referenced this issue Dec 6, 2020
tomasbjerre added a commit that referenced this issue Dec 6, 2020
@tomasbjerre
Copy link
Contributor

There is such an option now. Released as 1.126.

   ignorePaths: [
       [path: 'node_modules'],
       [path: '.yarn']
   ],

@bgotink
Copy link
Author

bgotink commented Dec 6, 2020

Great, thanks!

aakoch pushed a commit to aakoch/violation-comments-to-stash-plugin that referenced this issue Dec 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants