Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-46753] Fixed PCT failure against core 2.73.1 #3

Merged
merged 3 commits into from
Oct 14, 2017

Conversation

fcojfernandez
Copy link
Member

@fcojfernandez fcojfernandez commented Sep 8, 2017

JENKINS-46753

Fixed PCT failure against core 2.73.1. Missing dependency in scope test

@reviewbybees

@ghost
Copy link

ghost commented Sep 8, 2017

This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation.

@jglick jglick requested a review from andresrc October 4, 2017 21:06
pom.xml Outdated
@@ -6,7 +6,7 @@
<groupId>org.jenkins-ci.plugins</groupId>
<artifactId>plugin</artifactId>
<!-- Baseline Jenkins version you use to build and test the plugin. Users must have this version or newer to run. -->
<version>2.17</version>
<version>2.33</version>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fcojfernandez Why not the latest one?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Version 2.33 was latest version at the time of the Pull Request. At present time, latest version is 2.36. I've upgraded and tested.

@recena @andresrc what do you think about this upgrade now?

@recena recena merged commit 3688261 into jenkinsci:master Oct 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants