Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Remove parboiled as parsing engine #88

Merged
merged 9 commits into from
Feb 14, 2022
Merged

chore: Remove parboiled as parsing engine #88

merged 9 commits into from
Feb 14, 2022

Conversation

slide
Copy link
Member

@slide slide commented Nov 2, 2021

This removes parboiled as the parsing engine for tokens and replaces with a hand written parser.

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@slide slide marked this pull request as draft November 2, 2021 21:40
@slide slide marked this pull request as ready for review November 2, 2021 22:33
@slide slide merged commit 7c8f82a into jenkinsci:main Feb 14, 2022
@slide slide deleted the remove_parboiled branch February 14, 2022 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@basil basil basil approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@slide @basil