[JENKINS-54128] Deprecated calls to Run.getLogFile #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
varyvol
reviewed
Mar 19, 2020
| } | ||
|
|
||
| public String readLogFile(File file) throws IOException { | ||
| private String readLogFile(Run<?, ?> run) throws IOException { |
There was a problem hiding this comment.
Isn't changing the visibility a bit risky?
There was a problem hiding this comment.
It's a bit risky, yes. I am fine with it though
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See JENKINS-54128. Removes this plugin's usage of the deprecated
Run#getLogFilemethod, which has been deprecated as of JEP-210, in favor of the non-deprecatedRun#getLogReadermethod. The latter internally handles character set issues, so there is also no need to deal with the character set when calling the method. As a bonus, I also switched to the Java 7 try-with-resources syntax.