Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add charSet parameter to FILE macro #144

Merged
merged 2 commits into from
Nov 17, 2022

Conversation

slide
Copy link
Member

@slide slide commented Nov 16, 2022

Adds a charSet parameter to the FILE macro so that the user can specify the charset for reading the file if it is not the same as the default charSet for the JVM.

See https://issues.jenkins.io/browse/JENKINS-69770

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@slide slide merged commit 93c7f7f into jenkinsci:main Nov 17, 2022
@slide slide deleted the file_macro_charset branch November 17, 2022 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant