Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add escapeHtml parameter to all DataBoundTokenMacro implementations #118

Merged
merged 1 commit into from
Apr 20, 2022

Conversation

rsandell
Copy link
Member

This adds escapeHtml parameter to all macros extending from DataBoundTokenMacro i.e. any macro that takes a parameter. Any HTML content will be escaped with StringEscapeUtils.escapeHtml.
The implementing macro doesn't need to care by default about this parameter, but can do the escaping by itself by overriding handlesHtmlEscapeInternally and returning true.

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@slide slide merged commit d1aaca2 into jenkinsci:main Apr 20, 2022
@rsandell
Copy link
Member Author

@slide thanks for merging! Any chance to get it released? I think the CD release only kicks off if release drafter finds something interesting e.g. labeld with feature, bug etc.

@rsandell
Copy link
Member Author

Email Ext follow up: jenkinsci/email-ext-plugin#359

@slide
Copy link
Member

slide commented Apr 21, 2022

Yes, I will do it today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants