Support Declarative Syntax #109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
steven-terrana
added
2.0 Feature
Author Should Merge
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Details
This PR sets a > 0 ordinal on JTE's
GroovyShellDecoratorImplas part of the effort to support declarative syntax.According to the
@Extensionjavadocs, extensions with greater ordinal values are listed first.This ensures that the JTE compile-time changes take place prior to the compile-time parsing that declarative syntax does.
For more info, check out the corresponding pull request on pipeline-model-definition
marking this as a draft. will wait to see if there are changes on either side (JTE/Declarative) that we want to include to this.
Will need to write a page in the documentation that should be included in this PR prior to merging.