Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for library resources #102

Merged
merged 3 commits into from
Aug 11, 2020
Merged

Add support for library resources #102

merged 3 commits into from
Aug 11, 2020

Conversation

steven-terrana
Copy link

@steven-terrana steven-terrana commented Jul 22, 2020

PR Details

I ended up fixing some stuff related to building the documentation in this PR.

Adding library resources and changing the library file structure had some rippling changes across the library development documentation.

This caused me to reread the library development documentation and it.. needed some attention. So it was reorganized and more or less rewritten in some places.

fixes #46

Description

Adds support for fetching static assets in a library's resources directory through a resource utility method that's only available within library steps.

Fetching resources in another library is not supported. This is an intentional decision to nudge folks towards the best practice that libraries remain self-contained and to avoid the pitfall of colliding library resource relative paths across libraries.

How Has This Been Tested

Unit Testing
Integration testing with a real jenkins

Types of Changes

  • Added Unit Testing
  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have added the appropriate label for this PR
  • If necessary, I have updated the documentation accordingly.
  • All new and existing tests passed.

@steven-terrana steven-terrana merged commit ef133d2 into jenkinsci:2.0 Aug 11, 2020
@steven-terrana steven-terrana deleted the library-resources branch April 27, 2021 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant