[JENKINS-14606] - Fix issue with promoted build plugin #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The svn-tag plugin takes the environment variables from the ancestor build and not the actual build that was triggered. The issue can be solved if the environment variables from the actual build are put in the var map and then the ancestor build adds/overrides its environment variables to the map. That would not change the original behaviour of the svn-tag plugin but add the wanted functionality for it to work well together with the promoted build plugin. This is a fix for JENKINS-14606 Signed-off-by: Christian Gmeiner <[email protected]>
|
Thank you for this pull request! Please check this document for how the Jenkins project handles pull requests. |
oleg-nenashev
changed the title
| EnvVars envVars = rootBuild.getEnvironment(buildListener); | ||
| EnvVars envVars = abstractBuild.getEnvironment(buildListener); | ||
| EnvVars rootVars = rootBuild.getEnvironment(buildListener); | ||
| envVars.putAll(rootVars); |
There was a problem hiding this comment.
This change will cause a mess in common env vars like BUILD_NUMBER.
The inclusion order is correct, so the change should not break the original behavior of the plugin.
|
The change looks good for me. It would be useful to see some functional tests |
|
How shall functional tests look like? |
|
@austriancoder Actually I would expect a test, which
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The svn-tag plugin takes the environment variables from the ancestor build
and not the actual build that was triggered. The issue can be solved if the
environment variables from the actual build are put in the var map and then
the ancestor build adds/overrides its environment variables to the map. That
would not change the original behaviour of the svn-tag plugin but add the
wanted functionality for it to work well together with the promoted build plugin.
This is a fix for JENKINS-14606
Signed-off-by: Christian Gmeiner [email protected]