Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] Add "up" and "running" as stop words #577

Merged
merged 1 commit into from
Sep 5, 2024

Conversation

PierreBtz
Copy link
Contributor

If an instance contains jobs named "up" and/or "running", those end up being anonymized, leading to a log entry like: Jenkins is fully item_outer_pub and item_square_life.

This is not really convenient when browsing through the logs and looking for "up and running".

With this change, the log entry becomes Jenkins is up and running.

More generally, and outside of the context of this PR, I wonder if some groups of words should not be automatically excluded, like two letter words, adverbs etc...

Testing done

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@PierreBtz PierreBtz requested a review from a team as a code owner September 5, 2024 07:18
@Dohbedoh
Copy link
Contributor

Dohbedoh commented Sep 5, 2024

More generally, and outside of the context of this PR, I wonder if some groups of words should not be automatically excluded, like two letter words, adverbs etc...

Yeah could be included as part of supporting regexps: https://issues.jenkins.io/browse/JENKINS-71841

@Dohbedoh Dohbedoh added this pull request to the merge queue Sep 5, 2024
Merged via the queue into jenkinsci:master with commit a1d6d0e Sep 5, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants