Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-73281] Use mina-sshd-api plugin #297

Merged
merged 1 commit into from
Jun 24, 2024
Merged

Conversation

basil
Copy link
Member

@basil basil commented Jun 21, 2024

See JENKINS-73281. The sample-plugin test in jenkinsci/bom started failing on the Jetty 12 EE 8 branch with the stack trace shown in the ticket. The root cause of the problem was unrelated to the Jetty 12 EE 8 upgrade but happened to be exposed by the reshuffled classpath of Jetty 12 EE 8; namely, the Subversion test JAR was pulling in an old version of mina-sshd-api-common. Somehow the reshuffled classpath on Jetty 12 EE 8 made this old version take precedence, resulting in the failure:

[INFO] +- org.jenkins-ci.plugins:subversion:jar:1256.vee91953217b_6:test
[INFO] |  +- org.tmatesoft.svnkit:svnkit:jar:1.10.10:test
[INFO] |  |  +- org.apache.sshd:sshd-common:jar:2.8.0:test <---- outdated version that causes `InjectedTest` to fail

The fix is to exclude this old version to allow (the latest version of) this library to be pulled in from the corresponding library plugin.

Testing done

Reproduced the problem described in the ticket in jenkinsci/bom; with the incremental build from this PR, can no longer reproduce the issue.

@basil basil requested a review from jtnord June 21, 2024 19:28
@basil basil marked this pull request as ready for review June 21, 2024 19:28
@basil basil merged commit 4b6d7cd into jenkinsci:master Jun 24, 2024
15 checks passed
@basil basil deleted the mina branch June 24, 2024 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants