Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-37184] [JENKINS-5124] Log the exception that is thrown if Jenksins can't get info() on a subversion repository using a tunnel #165

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

[JENKINS-37184] [JENKINS-5124] Log the exception that is thrown if Jenksins can't get info() on a subversion repository using a tunnel #165

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
55041f6
Fixes JENKINS-37184 and JENKINS-5124
openbrian Aug 4, 2016
a1bce01
fix coding style
openbrian Aug 4, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/main/java/hudson/scm/listtagsparameter/ListSubversionTagsParameterDefinition.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,6 +179,7 @@ context, getTagsDir(), getCredentialsId(), null
SVNURL repoURL = SVNURL.parseURIDecoded(getTagsDir());

SVNRepository repo = SVNRepositoryFactory.create(repoURL);
repo.setTunnelProvider(SubversionSCM.createDefaultSVNOptions());
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not about logging, is it?

repo.setAuthenticationManager(authManager);
SVNLogClient logClient = new SVNLogClient(authManager, null);

Expand Down Expand Up @@ -255,6 +256,7 @@ private boolean isSVNRepositoryProjectRoot(SVNRepository repo) {
return true;
}
} catch (SVNException e) {
LOGGER.log(Level.SEVERE, "An SVN exception occurred", e);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The message does not provide any value

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's doesn't? It tells a sysadmin that they have a misconfigured repository line when they specify svn+foo://domain/path and foo is not a configured tunnel in .subversion/config. It's much better then throwing that exception on the floor. It's the only way I would know how to fix the bug.

return false;
}
return false;
Expand Down