Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test for future versions of jenkins - PCT failures #90

Merged
merged 2 commits into from
May 10, 2021
Merged

Fix test for future versions of jenkins - PCT failures #90

merged 2 commits into from
May 10, 2021

Conversation

res0nance
Copy link
Contributor

@res0nance res0nance commented May 8, 2021

Due to jenkinsci/jenkins#5275 a test breaks PCT and is blocking jenkinsci/bom#511.

Adapt the test to work for the plugin's version of jenkins and for the later releases of jenkins

Tested manually with mvn clean install -Djenkins.version=2.289

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your master branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@timja
Copy link
Member

timja commented May 8, 2021

@car-roll car-roll merged commit 6dd4a21 into jenkinsci:master May 10, 2021
@jglick
Copy link
Member

jglick commented May 10, 2021

Remember that for #92 to work you need to label PRs like this.

@car-roll car-roll added the test label May 11, 2021
@res0nance res0nance deleted the pct branch May 11, 2021 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants