Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify dependency from EE 10 to EE 9 && Migrate maven-example/Book.java to StaplerRequest2 & StaplerResponse2 #621

Merged
merged 3 commits into from
Jan 3, 2025

Conversation

ahmed-kamal2004
Copy link
Contributor

@ahmed-kamal2004 ahmed-kamal2004 commented Jan 3, 2025

Since Stapler is using Jakarta EE 9, Change the version of Jakarta to be 5.0.0 (EE 9)

@ahmed-kamal2004
Copy link
Contributor Author

ahmed-kamal2004 commented Jan 3, 2025

@basil, I found in maven-example, a problem in using JSP files as I believe it doesn't get it or search in it's path, please clearify to me if I misunderstood anything

maven-example
Screenshot from 2025-01-03 08-43-56

@ahmed-kamal2004 ahmed-kamal2004 changed the title Modify dependency from EE 10 to EE 9 Modify dependency from EE 10 to EE 9 && Migrate maven-example/Book.java to updated StaplerRequest2 & StaplerResponse2 Jan 3, 2025
@ahmed-kamal2004 ahmed-kamal2004 changed the title Modify dependency from EE 10 to EE 9 && Migrate maven-example/Book.java to updated StaplerRequest2 & StaplerResponse2 Modify dependency from EE 10 to EE 9 && Migrate maven-example/Book.java to StaplerRequest2 & StaplerResponse2 Jan 3, 2025
Copy link
Member

@basil basil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@basil basil merged commit 7262feb into jenkinsci:master Jan 3, 2025
0 of 2 checks passed
@ahmed-kamal2004
Copy link
Contributor Author

@basil Thanks, do we need to update "ant" example also?
or is there any new-comer issues in this repo I can work on ?

@basil
Copy link
Member

basil commented Jan 3, 2025

Not sure offhand.

@timja
Copy link
Member

timja commented Jan 3, 2025

@basil Thanks, do we need to update "ant" example also? or is there any new-comer issues in this repo I can work on ?

You could take a look at #483

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants