Migrate example to StaplerRequest2 & StaplerResponse2 #620
Conversation
|
@jenkinsci/lib-jenkins-stapler-support-developers please review |
jglick
changed the title
| @@ -24,7 +31,7 @@ | |||
| <dependency> | |||
| <groupId>jakarta.servlet</groupId> | |||
| <artifactId>jakarta.servlet-api</artifactId> | |||
| <version>5.0.0</version> | |||
| <version>6.1.0</version> | |||
There was a problem hiding this comment.
This is Jakarta EE 11, while this repository is currently on Java EE 9.
There was a problem hiding this comment.
Thanks for comment, I change it in a new pull request
but to make it clear, should change the version only or the whole dependency ?
because based on that commit
994adb3
the migration is towards Jakarta EE 9, thanks🙏🙏
There was a problem hiding this comment.
after returning to the mentioned commit, I found that I should have left the version to be 5.0.0, please tell me if I wrong.
There was a problem hiding this comment.
Agreed, this should have been left at 5.0.0 (EE 9). When the repository is upgraded to e.g. EE 10 in the future (cf. #617), we can upgrade it then.
Testing done