Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incrementalify plugin #6

Merged
merged 5 commits into from
Aug 4, 2022
Merged

Incrementalify plugin #6

merged 5 commits into from
Aug 4, 2022

Conversation

basil
Copy link
Member

@basil basil commented Aug 4, 2022

Making this plugin consistent with other core components that produce incremental builds that can be used for testing.

Comment on lines +1 to +15
target

# mvn hpi:run
work

# IntelliJ IDEA project files
*.iml
*.ipr
*.iws
target
*.ipr
.idea

# Eclipse project files
.settings
.classpath
.project
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consistent with the archetype.

Comment on lines -35 to -40
<distributionManagement>
<repository>
<id>repo.jenkins-ci.org</id>
<url>https://repo.jenkins-ci.org/public/</url>
</repository>
</distributionManagement>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No longer needed, as this is provided by the parent POM.

<maven.version>2.0.1</maven.version>
<spotbugs.skip>true</spotbugs.skip>
<spotbugs.threshold>High</spotbugs.threshold>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There were only a few high-priority SpotBugs warnings, so I suppressed them and turned this on so that we at least discover new high-priority SpotBugs warnings.

@@ -52,9 +47,11 @@
</pluginRepositories>

<properties>
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No longer needed, as this is provided by the parent POM.

@basil basil requested a review from NotMyFault August 4, 2022 14:18
@basil
Copy link
Member Author

basil commented Aug 4, 2022

Incrementalifying the plugin activates the Javadoc generation, which exposes some other problems. I'll try to fix that up.

@NotMyFault
Copy link
Member

I extracted the incremental part from #5 in order to prevent possible conficlits with the upcoming configuration.

@basil
Copy link
Member Author

basil commented Aug 4, 2022

Fixed the Javadoc generation by migrating to some more modern Maven annotations.

@basil basil merged commit 6c9dca1 into jenkinsci:master Aug 4, 2022
@basil basil deleted the incrementals branch August 4, 2022 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants