Add live theme switching support #47
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timja
commented
Feb 24, 2022
timja
commented
Feb 24, 2022
timja
commented
Feb 24, 2022
timja
commented
Feb 24, 2022
timja
commented
Feb 24, 2022
| @@ -71,7 +71,7 @@ | |||
| /* --font-size-monospace */ /* not a color */ | |||
| /* --font-size-sm */ /* not a color */ | |||
| /* --font-size-xs */ /* not a color */ | |||
| /* --header-bg-classic */ | |||
| --header-bg-classic: #000; | |||
There was a problem hiding this comment.
this wasn't set before and was relying on what was set in core.
It's one of the colours used in preview so needs to be set otherwise the active theme will show it's colour there:
https://github.com/jenkinsci/theme-manager-plugin/blob/master/src/main/resources/lib/theme-manager/selector.jelly#L31-L37
NotMyFault
approved these changes
Apr 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See jenkinsci/theme-manager-plugin#75
All themes are now loaded on every page, the active theme is controlled by a
dataattribute on thehtmlelement.Given not many variables are overridden for the
light/darkthemes I just duplicated them below each other.If that's not wanted then I can introduce some preprocessing like done in the Dark theme PR jenkinsci/dark-theme-plugin#170
FYI @janfaracik