Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade versions and dependencies #141

Merged
merged 1 commit into from
Aug 23, 2023

Conversation

j-luong
Copy link
Collaborator

@j-luong j-luong commented Aug 18, 2023

This PR updates the minimum Jenkins version to the current LTS and updates any required dependencies. This should reduce the number of critical and high SCA vulnerabilities detected by Snyk

New Requirements

  • Plugin requires Java 11
  • Plugin requires Jenkins 2.401.3+

Tested and working using a Docker Jenkins instance built on jenkins/jenkins:lts:
Screenshot 2023-08-22 at 12 31 43
Screenshot 2023-08-22 at 12 32 08

Testing done

Submitter checklist

pom.xml Outdated
<artifactId>jenkins-test-harness</artifactId>
<version>2034.v41c9cb_349299</version>
<scope>test</scope>
<exclusions>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where does the included test-harness come from? And why is it a conflict?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updating org.jenkins-ci.plugins.plugin to the latest version (4.71) fixed this issue.

@bastiandoetsch
Copy link
Collaborator

bastiandoetsch commented Aug 18, 2023

Please update the changelog - the commits going into the release should explain new requirements (e.g. LTS, Java 11, ...). Also the release text once we release.

@j-luong j-luong added the dependencies Pull requests that update a dependency file label Aug 22, 2023
@j-luong j-luong force-pushed the chore/HEAD-242-upgradeVersions branch 11 times, most recently from 59374eb to ffbc742 Compare August 22, 2023 18:54
* Plugin requires Java 11
* Plugin requires Jenkins 2.401.3+
* Update Jenkins version
* Update Jenkins CI plugin version
* Update various depedencies
@j-luong j-luong force-pushed the chore/HEAD-242-upgradeVersions branch from ffbc742 to 85ecc4a Compare August 23, 2023 08:49
@j-luong j-luong marked this pull request as ready for review August 23, 2023 08:49
@j-luong j-luong merged commit 040386a into master Aug 23, 2023
14 checks passed
@j-luong j-luong deleted the chore/HEAD-242-upgradeVersions branch August 23, 2023 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants