[FIXED JENKINS-40113] sematic-versioning-plugin causes dashboard to biff #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Relation to jenkinsci/jenkins#2459? |
jglick
suggested changes
Jan 6, 2017
| @@ -83,7 +83,7 @@ public SemanticVersionColumnDescriptor() { | |||
|
|
|||
| @Override | |||
| public ListViewColumn newInstance(StaplerRequest req, JSONObject formData) throws FormException { | |||
| String strategy = formData == null ? LastSuccessfulBuildStrategy.class.getCanonicalName() : formData.getString("displayStrategy"); | |||
| String strategy = formData == null ? LastSuccessfulBuildStrategy.class.getCanonicalName() : formData.optString("displayStrategy"); | |||
There was a problem hiding this comment.
I think you meant
String strategy = formData == null ? null : formData.optString("displayStrategy");
if (strategy == null) {
strategy = LastSuccessfulBuildStrategy.class.getCanonicalName();
}
|
@jglick Root cause seems to be this change jenkinsci/jenkins@8c73550 |
stephenc
force-pushed
the
jenkins-40113
branch
from
3ab89b6 to
07d2b75
Compare
|
@jglick ping |
|
🐝 |
|
This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation. |
|
@reviewbybees done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See JENKINS-40113
@reviewbybees