- Refactored to use extension model #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e which pareser the build uses
|
plugins » semantic-versioning-plugin #28 SUCCESS |
|
Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests |
ciroque
added a commit
that referenced
this pull request
Jun 25, 2014
- Refactored to use extension model
|
Sweet! I have been having issues building this and getting it published to jenkins-ci.org. I will try to work out the problems in the next couple of days. I am interested in getting both pull requests completed recently into circulation. |
|
If you need any help with these changes don't be afraid to ask :) I will be pleased to help. |
|
Thanks, got it figured out and published the new version. Simple PEBCAK that some reading resolved ;-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I refactored semantic-versioning-plugin to use extension point model so it can be extended with new semantic parsers in example ANT-parser.
I also refactored Pom Parser to resolve build file (pom.xml) from given root pom parameter, because at least in our build pom.xml locates at /<workspace_root>/workspace/<project_name>/pom.xml folder
and third and last modification is that now it is possible to select which parserer is used in that particular build job.