Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add badge #550

Merged
merged 1 commit into from
Jan 3, 2024
Merged

add badge #550

merged 1 commit into from
Jan 3, 2024

Conversation

mawinter69
Copy link
Contributor

@mawinter69 mawinter69 commented Dec 21, 2023

adds a badge to the management link and dropdown menu
The badge will be yellow when there are only pending approvals and red when there are approved dangerous signatures.

image

Testing done

Interactive testing

Submitter checklist

adds a badge to the management link and dropdown menu
@mawinter69 mawinter69 requested a review from a team as a code owner December 21, 2023 17:32
@mawinter69
Copy link
Contributor Author

One might consider either completely removing the info about pending approvals in the description or have just a short summary, e.g. Approvals pending and/or Dangerous Approvals

Copy link
Member

@NotMyFault NotMyFault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UI wise, the change fits perfectly into our theme :)

@jglick
Copy link
Member

jglick commented Jan 3, 2024

One might consider…

Feel free to propose a PR to that effect.

@jglick jglick merged commit 4874331 into jenkinsci:master Jan 3, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants